diff --git a/Libraries/LibCore/CNetworkJob.cpp b/Libraries/LibCore/CNetworkJob.cpp index f668fac9a3..7cc563f26b 100644 --- a/Libraries/LibCore/CNetworkJob.cpp +++ b/Libraries/LibCore/CNetworkJob.cpp @@ -14,6 +14,10 @@ CNetworkJob::~CNetworkJob() void CNetworkJob::did_finish(NonnullRefPtr&& response) { + // NOTE: We protect ourselves here, since the on_finish callback may otherwise + // trigger destruction of this job somehow. + NonnullRefPtr protector(*this); + m_response = move(response); #ifdef CNETWORKJOB_DEBUG dbg() << *this << " job did_finish!"; @@ -25,6 +29,10 @@ void CNetworkJob::did_finish(NonnullRefPtr&& response) void CNetworkJob::did_fail(Error error) { + // NOTE: We protect ourselves here, since the on_finish callback may otherwise + // trigger destruction of this job somehow. + NonnullRefPtr protector(*this); + m_error = error; #ifdef CNETWORKJOB_DEBUG dbgprintf("%s{%p} job did_fail! error: %u (%s)\n", class_name(), this, (unsigned)error, to_string(error));