RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:47:45 +00:00
Code Issues Activity Actions

LibChess: Remove use of DeprecatedString in Move::from_algebraic()

Browse source
This commit is contained in:
Sam Atkins 2023-04-24 13:00:09 +01:00 • committed by Andreas Kling
parent a10cc37ef0
commit 20d517f1da
1 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Userland/Libraries/LibChess/Chess.cpp
View file

@ -118,7 +118,7 @@ ErrorOr<String> Move::to_long_algebraic() const
Move Move::from_algebraic(StringView algebraic, const Color turn, Board const& board) Move Move::from_algebraic(StringView algebraic, const Color turn, Board const& board)
{ {
DeprecatedString move_string = algebraic; auto move_string = algebraic;
Move move({ 50, 50 }, { 50, 50 }); Move move({ 50, 50 }, { 50, 50 });
if (move_string.contains('-')) { if (move_string.contains('-')) {
@ -132,10 +132,10 @@ Move Move::from_algebraic(StringView algebraic, const Color turn, Board const& b
if (algebraic.contains('#')) { if (algebraic.contains('#')) {
move.is_mate = true; move.is_mate = true;
move_string = move_string.substring(0, move_string.length() - 1); move_string = move_string.substring_view(0, move_string.length() - 1);
} else if (algebraic.contains('+')) { } else if (algebraic.contains('+')) {
move.is_check = true; move.is_check = true;
move_string = move_string.substring(0, move_string.length() - 1); move_string = move_string.substring_view(0, move_string.length() - 1);
} }
if (algebraic.contains('=')) { if (algebraic.contains('=')) {
@ -144,36 +144,36 @@ Move Move::from_algebraic(StringView algebraic, const Color turn, Board const& b
move_string = parts[0]; move_string = parts[0];
} }
move.to = Square(move_string.substring(move_string.length() - 2, 2)); move.to = Square(move_string.substring_view(move_string.length() - 2, 2));
move_string = move_string.substring(0, move_string.length() - 2); move_string = move_string.substring_view(0, move_string.length() - 2);
if (move_string.contains('x')) { if (move_string.contains('x')) {
move.is_capture = true; move.is_capture = true;
move_string = move_string.substring(0, move_string.length() - 1); move_string = move_string.substring_view(0, move_string.length() - 1);
} }
if (move_string.is_empty() || move_string.characters()[0] >= 'a') { if (move_string.is_empty() || move_string[0] >= 'a') {
move.piece = Piece(turn, Type::Pawn); move.piece = Piece(turn, Type::Pawn);
} else { } else {
move.piece = Piece(turn, piece_from_char(move_string[0])); move.piece = Piece(turn, piece_from_char(move_string[0]));
move_string = move_string.substring(1, move_string.length() - 1); move_string = move_string.substring_view(1, move_string.length() - 1);
} }
Square::for_each([&](Square const& square) { Square::for_each([&](Square const& square) {
if (!move_string.is_empty()) { if (!move_string.is_empty()) {
if (board.get_piece(square).type == move.piece.type && board.is_legal(Move(square, move.to), turn)) { if (board.get_piece(square).type == move.piece.type && board.is_legal(Move(square, move.to), turn)) {
if (move_string.length() >= 2) { if (move_string.length() >= 2) {
if (square == Square(move_string.substring(0, 2))) { if (square == Square(move_string.substring_view(0, 2))) {
move.from = square; move.from = square;
return IterationDecision::Break; return IterationDecision::Break;
} }
} else if (move_string.characters()[0] <= 57) { } else if (move_string[0] <= 57) {
if (square.rank == (move_string.characters()[0] - '0')) { if (square.rank == (move_string[0] - '0')) {
move.from = square; move.from = square;
return IterationDecision::Break; return IterationDecision::Break;
} }
} else { } else {
if (square.file == (move_string.characters()[0] - 'a')) { if (square.file == (move_string[0] - 'a')) {
move.from = square; move.from = square;
return IterationDecision::Break; return IterationDecision::Break;
} }