RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:27:43 +00:00
Code Issues Activity Actions

LibGUI: Don't bubble window events up to parent windows

Browse source 
Always accept the events so that they don't bubble up to the
parent object.

Fixes #4967
This commit is contained in:
Tom 2021-01-15 20:52:06 -07:00 • committed by Andreas Kling
parent d312011708
commit 20f53c7462
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibGUI/Window.cpp
View file

@ -27,6 +27,7 @@
#include <AK/HashMap.h>
#include <AK/JsonObject.h>
#include <AK/NeverDestroyed.h>
#include <AK/ScopeGuard.h>
#include <LibCore/EventLoop.h>
#include <LibCore/MimeData.h>
#include <LibGUI/Action.h>
@ -490,6 +491,10 @@ void Window::handle_left_event()
void Window::event(Core::Event& event)
{
ScopeGuard guard([&] {
// Accept the event so it doesn't bubble up to parent windows!
event.accept();
});
if (event.type() == Event::Drop)
return handle_drop_event(static_cast<DropEvent&>(event));