RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:37:45 +00:00
Code Issues Activity Actions

LibMarkdown: Change internal MD API to return OwnPtrs

Browse source 
Previously, all Markdown blocks had a virtual parse method which has
been swapped out for a static parse method returning an OwnPtr of
that block's type.

The Text class also now has a static parse method that will return an
Optional<Text>.
This commit is contained in:
FalseHonesty 2020-05-18 16:58:00 -04:00 • committed by Andreas Kling
parent 7ca562b200
commit 20faa93cb0
15 changed files with 110 additions and 64 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibMarkdown/List.h
View file

@ -26,6 +26,7 @@
#pragma once
#include <AK/OwnPtr.h>
#include <AK/Vector.h>
#include <LibMarkdown/Block.h>
#include <LibMarkdown/Text.h>
@ -34,11 +35,17 @@ namespace Markdown {
class List final : public Block {
public:
List(Vector<Text>&& text, bool is_ordered)
: m_items(move(text))
, m_is_ordered(is_ordered)
{
}
virtual ~List() override {}
virtual String render_to_html() const override;
virtual String render_for_terminal() const override;
virtual bool parse(Vector<StringView>::ConstIterator& lines) override;
static OwnPtr<List> parse(Vector<StringView>::ConstIterator& lines);
private:
// TODO: List items should be considered blocks of their own kind.