RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:17:35 +00:00
Code Issues Activity Actions

LibMarkdown: Change internal MD API to return OwnPtrs

Browse source 
Previously, all Markdown blocks had a virtual parse method which has
been swapped out for a static parse method returning an OwnPtr of
that block's type.

The Text class also now has a static parse method that will return an
Optional<Text>.
This commit is contained in:
FalseHonesty 2020-05-18 16:58:00 -04:00 • committed by Andreas Kling
parent 7ca562b200
commit 20faa93cb0
15 changed files with 110 additions and 64 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Libraries/LibMarkdown/Paragraph.cpp
View file

@ -46,10 +46,10 @@ String Paragraph::render_for_terminal() const
return builder.build();
}
bool Paragraph::parse(Vector<StringView>::ConstIterator& lines)
OwnPtr<Paragraph> Paragraph::parse(Vector<StringView>::ConstIterator& lines)
{
if (lines.is_end())
return false;
return nullptr;
bool first = true;
StringBuilder builder;
@ -86,11 +86,13 @@ bool Paragraph::parse(Vector<StringView>::ConstIterator& lines)
}
if (first)
return false;
return nullptr;
bool success = m_text.parse(builder.build());
ASSERT(success);
return true;
auto text = Text::parse(builder.build());
if (!text.has_value())
return nullptr;
return make<Paragraph>(move(text.value()));
}
}