RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 14:42:44 +00:00
Code Issues Activity Actions

CEventLoop: Create the wake pipe with O_CLOEXEC

Browse source 
This ensures the pipe fds don't leak into child processes.
This manifested as the Shell (and all processes started
from the shell) having two mysterious FIFOs open. This
was happening because of the Terminal, which the shell
was spawned form, leaking its CEventLoop wake pipe fds.
This commit is contained in:
Sergey Bugaev 2019-08-05 15:31:38 +03:00 • committed by Andreas Kling
parent 9c3b1ca0c6
commit 211b51dab7
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibCore/CEventLoop.cpp
View file

@ -36,7 +36,7 @@ CEventLoop::CEventLoop()
if (!s_main_event_loop) {
s_main_event_loop = this;
int rc = pipe(s_wake_pipe_fds);
int rc = pipe2(s_wake_pipe_fds, O_CLOEXEC);
ASSERT(rc == 0);
s_event_loop_stack->append(this);
}