RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:57:35 +00:00
Code Issues Activity Actions

Revert "LibGUI: Only dispatch Leave if the now-hovered widget isn't a child"

Browse source 
This reverts commit cfc9ee6f16.

This change was wrong: The parent *does* lose hover when the mouse
cursor enters a child widget. Hover is not hierarchical, there is only a
hovered window and a hovered widget within that window.

This fixes an issue with GUI::TabWidget buttons appearing hovered
despite the mouse cursor not being over the buttons.
This commit is contained in:
Andreas Kling 2021-07-28 21:24:29 +02:00
parent 230f7ce71c
commit 2135c66823
3 changed files with 1 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibGUI/Widget.cpp
View file

@ -1143,20 +1143,4 @@ bool Widget::is_visible_for_timer_purposes() const
return is_visible() && Object::is_visible_for_timer_purposes();
}
bool Widget::is_parent_of(Widget const* widget) const
{
if (widget == nullptr)
return false;
Widget const* current_widget = widget->parent_widget();
while (current_widget != nullptr) {
if (current_widget == this)
return true;
current_widget = current_widget->parent_widget();
}
return false;
}
}