RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:37:35 +00:00
Code Issues Activity Actions

Revert "LibGUI: Only dispatch Leave if the now-hovered widget isn't a child"

Browse source 
This reverts commit cfc9ee6f16.

This change was wrong: The parent *does* lose hover when the mouse
cursor enters a child widget. Hover is not hierarchical, there is only a
hovered window and a hovered widget within that window.

This fixes an issue with GUI::TabWidget buttons appearing hovered
despite the mouse cursor not being over the buttons.
This commit is contained in:
Andreas Kling 2021-07-28 21:24:29 +02:00
parent 230f7ce71c
commit 2135c66823
3 changed files with 1 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/Window.cpp
View file

@ -802,7 +802,7 @@ void Window::set_hovered_widget(Widget* widget)
if (widget == m_hovered_widget)
return;
if (m_hovered_widget && !m_hovered_widget->is_parent_of(widget))
if (m_hovered_widget)
Core::EventLoop::current().post_event(*m_hovered_widget, make<Event>(Event::Leave));
m_hovered_widget = widget;