RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:57:35 +00:00
Code Issues Activity Actions

LibJS: Remove Bytecode::Interpreter::debug_position()

Browse source 
This was only used in one place, and that place is already covered
by a VERIFY anyway.
This commit is contained in:
Andreas Kling 2023-09-26 15:36:45 +02:00
parent 0c746366cc
commit 213b835b57
3 changed files with 0 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Bytecode/Interpreter.cpp
View file

@ -339,12 +339,6 @@ ThrowCompletionOr<void> Interpreter::continue_pending_unwind(Label const& resume
return {}; return {};
} }
DeprecatedString Interpreter::debug_position() const
{
auto offset = m_pc.has_value() ? m_pc->offset() : 0;
return DeprecatedString::formatted("{}:{:2}:{:4x}", m_current_executable->name, m_current_block->name(), offset);
}
ThrowCompletionOr<NonnullOwnPtr<Bytecode::Executable>> compile(VM& vm, ASTNode const& node, FunctionKind kind, DeprecatedFlyString const& name) ThrowCompletionOr<NonnullOwnPtr<Bytecode::Executable>> compile(VM& vm, ASTNode const& node, FunctionKind kind, DeprecatedFlyString const& name)
{ {
auto executable_result = Bytecode::Generator::generate(node, kind); auto executable_result = Bytecode::Generator::generate(node, kind);

1
Userland/Libraries/LibJS/Bytecode/Interpreter.h
View file

@ -88,7 +88,6 @@ public:
Executable const& current_executable() const { return *m_current_executable; } Executable const& current_executable() const { return *m_current_executable; }
BasicBlock const& current_block() const { return *m_current_block; } BasicBlock const& current_block() const { return *m_current_block; }
auto& instruction_stream_iterator() const { return m_pc; } auto& instruction_stream_iterator() const { return m_pc; }
DeprecatedString debug_position() const;
void visit_edges(Cell::Visitor&); void visit_edges(Cell::Visitor&);

5
Userland/Libraries/LibJS/Bytecode/Op.cpp
View file

@ -855,11 +855,6 @@ static MarkedVector<Value> argument_list_evaluation(Bytecode::Interpreter& inter
MarkedVector<Value> argument_values { vm.heap() }; MarkedVector<Value> argument_values { vm.heap() };
auto arguments = interpreter.accumulator(); auto arguments = interpreter.accumulator();
if (!(arguments.is_object() && is<Array>(arguments.as_object()))) {
dbgln("[{}] Call arguments are not an array, but: {}", interpreter.debug_position(), arguments.to_string_without_side_effects());
interpreter.current_executable().dump();
VERIFY_NOT_REACHED();
}
auto& argument_array = arguments.as_array(); auto& argument_array = arguments.as_array();
auto array_length = argument_array.indexed_properties().array_like_size(); auto array_length = argument_array.indexed_properties().array_like_size();