RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 15:47:42 +00:00
Code Issues Activity Actions

LibJS: Convert values to boolean for JumpIfTrue/JumpIfFalse

Browse source 
Value::as_bool() might fail if the underlying value isn't already a
boolean value.
This commit is contained in:
Gunnar Beutner 2021-06-07 22:53:33 +02:00 • committed by Andreas Kling
parent aefb7995f1
commit 216d27d4c1
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Bytecode/Op.cpp
View file

@ -153,7 +153,7 @@ void JumpIfFalse::execute(Bytecode::Interpreter& interpreter) const
{ {
VERIFY(m_target.has_value()); VERIFY(m_target.has_value());
auto result = interpreter.reg(m_result); auto result = interpreter.reg(m_result);
if (!result.as_bool()) if (!result.to_boolean())
interpreter.jump(m_target.value()); interpreter.jump(m_target.value());
} }
@ -161,7 +161,7 @@ void JumpIfTrue::execute(Bytecode::Interpreter& interpreter) const
{ {
VERIFY(m_target.has_value()); VERIFY(m_target.has_value());
auto result = interpreter.reg(m_result); auto result = interpreter.reg(m_result);
if (result.as_bool()) if (result.to_boolean())
interpreter.jump(m_target.value()); interpreter.jump(m_target.value());
} }