RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 20:07:34 +00:00
Code Issues Activity Actions

AK: Remove the fallible constructor from FixedMemoryStream

Browse source
This commit is contained in:
Tim Schumacher 2023-01-30 11:05:43 +01:00 • committed by Linus Groh
parent 8b2f23d016
commit 220fbcaa7e
31 changed files with 185 additions and 209 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Meta/Lagom/Fuzzers/FuzzBrotli.cpp
View file

@ -10,14 +10,9 @@
extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
{
auto bufstream_result = FixedMemoryStream::construct({ data, size });
if (bufstream_result.is_error()) {
dbgln("MemoryStream::construct() failed.");
return 0;
}
auto bufstream = bufstream_result.release_value();
FixedMemoryStream bufstream { { data, size } };
auto brotli_stream = Compress::BrotliDecompressionStream { *bufstream };
auto brotli_stream = Compress::BrotliDecompressionStream { bufstream };
(void)brotli_stream.read_until_eof();
return 0;

2
Meta/Lagom/Fuzzers/FuzzTar.cpp
View file

@ -12,7 +12,7 @@
extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
{
auto input_stream_or_error = FixedMemoryStream::construct({ data, size });
auto input_stream_or_error = try_make<FixedMemoryStream>(ReadonlyBytes { data, size });
if (input_stream_or_error.is_error())
return 0;

7
Meta/Lagom/Fuzzers/FuzzWasmParser.cpp
View file

@ -12,10 +12,7 @@
extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
{
ReadonlyBytes bytes { data, size };
auto stream_or_error = FixedMemoryStream::construct(bytes);
if (stream_or_error.is_error())
return 0;
auto stream = stream_or_error.release_value();
[[maybe_unused]] auto result = Wasm::Module::parse(*stream);
FixedMemoryStream stream { bytes };
[[maybe_unused]] auto result = Wasm::Module::parse(stream);
return 0;
}

8
Meta/Lagom/Tools/CodeGenerators/IPCCompiler/main.cpp
View file

@ -586,8 +586,8 @@ public:
static ErrorOr<NonnullOwnPtr<IPC::Message>> decode_message(ReadonlyBytes buffer, [[maybe_unused]] Core::Stream::LocalSocket& socket)
{
auto stream = TRY(FixedMemoryStream::construct(buffer));
auto message_endpoint_magic = TRY(stream->read_value<u32>());)~~~");
FixedMemoryStream stream { buffer };
auto message_endpoint_magic = TRY(stream.read_value<u32>());)~~~");
generator.append(R"~~~(
if (message_endpoint_magic != @endpoint.magic@) {)~~~");
@ -599,7 +599,7 @@ public:
return Error::from_string_literal("Endpoint magic number mismatch, not my message!");
}
auto message_id = TRY(stream->read_value<i32>());)~~~");
auto message_id = TRY(stream.read_value<i32>());)~~~");
generator.appendln(R"~~~(
switch (message_id) {)~~~");
@ -613,7 +613,7 @@ public:
message_generator.append(R"~~~(
case (int)Messages::@endpoint.name@::MessageID::@message.pascal_name@:
return TRY(Messages::@endpoint.name@::@message.pascal_name@::decode(*stream, socket));)~~~");
return TRY(Messages::@endpoint.name@::@message.pascal_name@::decode(stream, socket));)~~~");
};
do_decode_message(message.name);