RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 21:58:10 +00:00
Code Issues Activity Actions

Shell: Use strncmp() instead of string.compare() for name completions

Browse source 
The "at most n bytes" behaviour of strncmp is required for this logic to
work, this was overlooked in 5b64abe when converting Strings to
StringViews, which lead to broken autocomplete.
This commit is contained in:
Ali Mohammad Pur 2022-02-05 14:36:34 +03:30 • committed by Ali Mohammad Pur
parent 14d1601a76
commit 222e580fa8
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Shell/Shell.cpp
View file

@ -1453,7 +1453,12 @@ Vector<Line::CompletionSuggestion> Shell::complete_program_name(StringView name,
cached_path.span(), cached_path.span(),
name, name,
nullptr, nullptr,
[](auto& name, auto& program) { return name.compare(program.view()); }); [](auto& name, auto& program) {
return strncmp(
name.characters_without_null_termination(),
program.characters(),
name.length());
});
if (!match) if (!match)
return complete_path("", name, offset, ExecutableOnly::Yes); return complete_path("", name, offset, ExecutableOnly::Yes);