RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:17:34 +00:00
Code Issues Activity Actions

LibPDF: Add two FIXMEs

Browse source
This commit is contained in:
Nico Weber 2023-10-12 10:18:46 -04:00 • committed by Andreas Kling
parent d451197d3d
commit 2249e79630
2 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibPDF/Encoding.cpp
View file

@ -23,6 +23,9 @@ PDFErrorOr<NonnullRefPtr<Encoding>> Encoding::from_object(Document* document, No
auto name = obj->cast<NameObject>()->name(); auto name = obj->cast<NameObject>()->name();
if (name == "StandardEncoding") if (name == "StandardEncoding")
return standard_encoding(); return standard_encoding();
// FIXME: MacExpertEncoding
if (name == "MacRomanEncoding") if (name == "MacRomanEncoding")
return mac_encoding(); return mac_encoding();
if (name == "WinAnsiEncoding") if (name == "WinAnsiEncoding")

1
Userland/Libraries/LibPDF/Fonts/CFF.cpp
View file

@ -388,6 +388,7 @@ PDFErrorOr<Vector<DeprecatedFlyString>> CFF::parse_charset(Reader&& reader, size
auto resolve = [](SID sid) { auto resolve = [](SID sid) {
if (sid < s_cff_builtin_names.size()) if (sid < s_cff_builtin_names.size())
return DeprecatedFlyString(s_cff_builtin_names[sid]); return DeprecatedFlyString(s_cff_builtin_names[sid]);
// FIXME: Read from String INDEX instead.
dbgln("Cound't find string for SID {}, going with space", sid); dbgln("Cound't find string for SID {}, going with space", sid);
return DeprecatedFlyString("space"); return DeprecatedFlyString("space");
}; };