RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:37:35 +00:00
Code Issues Activity Actions

LibJS/JIT: Compile the CreateVariable bytecode instruction

Browse source
This commit is contained in:
Simon Wanner 2023-10-29 02:26:15 +02:00 • committed by Andreas Kling
parent 54f1f7a51b
commit 224f92f6e4
3 changed files with 44 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -410,6 +410,12 @@ public:
ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const; ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const;
DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const; DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const;
IdentifierTableIndex identifier() const { return m_identifier; }
EnvironmentMode mode() const { return m_mode; }
bool is_immutable() const { return m_is_immutable; }
bool is_global() const { return m_is_global; }
bool is_strict() const { return m_is_strict; }
private: private:
IdentifierTableIndex m_identifier; IdentifierTableIndex m_identifier;
EnvironmentMode m_mode; EnvironmentMode m_mode;

36
Userland/Libraries/LibJS/JIT/Compiler.cpp
View file

@ -960,6 +960,39 @@ void Compiler::compile_typeof_variable(Bytecode::Op::TypeofVariable const& op)
check_exception(); check_exception();
} }
static Value cxx_create_variable(
VM& vm,
DeprecatedFlyString const& name,
Bytecode::Op::EnvironmentMode mode,
bool is_global,
bool is_immutable,
bool is_strict)
{
TRY_OR_SET_EXCEPTION(Bytecode::create_variable(vm, name, mode, is_global, is_immutable, is_strict));
return {};
}
void Compiler::compile_create_variable(Bytecode::Op::CreateVariable const& op)
{
m_assembler.mov(
Assembler::Operand::Register(ARG1),
Assembler::Operand::Imm(bit_cast<u64>(&m_bytecode_executable.get_identifier(op.identifier().value()))));
m_assembler.mov(
Assembler::Operand::Register(ARG2),
Assembler::Operand::Imm(to_underlying(op.mode())));
m_assembler.mov(
Assembler::Operand::Register(ARG3),
Assembler::Operand::Imm(static_cast<u64>(op.is_global())));
m_assembler.mov(
Assembler::Operand::Register(ARG4),
Assembler::Operand::Imm(static_cast<u64>(op.is_immutable())));
m_assembler.mov(
Assembler::Operand::Register(ARG5),
Assembler::Operand::Imm(static_cast<u64>(op.is_strict())));
native_call((void*)cxx_create_variable);
check_exception();
}
static Value cxx_set_variable( static Value cxx_set_variable(
VM& vm, VM& vm,
DeprecatedFlyString const& identifier, DeprecatedFlyString const& identifier,
@ -1208,6 +1241,9 @@ OwnPtr<NativeExecutable> Compiler::compile(Bytecode::Executable& bytecode_execut
case Bytecode::Instruction::Type::ConcatString: case Bytecode::Instruction::Type::ConcatString:
compiler.compile_concat_string(static_cast<Bytecode::Op::ConcatString const&>(op)); compiler.compile_concat_string(static_cast<Bytecode::Op::ConcatString const&>(op));
break; break;
case Bytecode::Instruction::Type::CreateVariable:
compiler.compile_create_variable(static_cast<Bytecode::Op::CreateVariable const&>(op));
break;
# define DO_COMPILE_COMMON_BINARY_OP(TitleCaseName, snake_case_name) \ # define DO_COMPILE_COMMON_BINARY_OP(TitleCaseName, snake_case_name) \
case Bytecode::Instruction::Type::TitleCaseName: \ case Bytecode::Instruction::Type::TitleCaseName: \

2
Userland/Libraries/LibJS/JIT/Compiler.h
View file

@ -101,6 +101,8 @@ private:
void compile_new_regexp(Bytecode::Op::NewRegExp const&); void compile_new_regexp(Bytecode::Op::NewRegExp const&);
void compile_new_bigint(Bytecode::Op::NewBigInt const&); void compile_new_bigint(Bytecode::Op::NewBigInt const&);
void compile_create_variable(Bytecode::Op::CreateVariable const&);
void compile_get_by_id(Bytecode::Op::GetById const&); void compile_get_by_id(Bytecode::Op::GetById const&);
void compile_get_by_value(Bytecode::Op::GetByValue const&); void compile_get_by_value(Bytecode::Op::GetByValue const&);
void compile_get_global(Bytecode::Op::GetGlobal const&); void compile_get_global(Bytecode::Op::GetGlobal const&);