RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:08:11 +00:00
Code Issues Activity Actions

LibGL: Set rasterizer material state without copying

Browse source 
Each of the material faces is copied member by member then the copied
material state is passed by `const&` to another function, then
destroyed.

This is changed to simply passing the material state directly without
copying.
This commit is contained in:
Lenny Maiorani 2022-01-26 20:46:26 -07:00 • committed by Linus Groh
parent 354017e01d
commit 229188b815
1 changed files with 2 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibGL/SoftwareGLContext.cpp
View file

@ -3158,22 +3158,8 @@ void SoftwareGLContext::sync_light_state()
m_rasterizer.set_light_state(light_id, current_light_state);
}
auto update_material_state = [&](SoftGPU::Face face, SoftGPU::Material const& current_material_state) {
SoftGPU::Material material;
material.ambient = current_material_state.ambient;
material.diffuse = current_material_state.diffuse;
material.specular = current_material_state.specular;
material.emissive = current_material_state.emissive;
material.shininess = current_material_state.shininess;
material.ambient_color_index = current_material_state.ambient_color_index;
material.diffuse_color_index = current_material_state.diffuse_color_index;
material.specular_color_index = current_material_state.specular_color_index;
m_rasterizer.set_material_state(face, material);
};
update_material_state(SoftGPU::Face::Front, m_material_states[Face::Front]);
update_material_state(SoftGPU::Face::Back, m_material_states[Face::Back]);
m_rasterizer.set_material_state(SoftGPU::Face::Front, m_material_states[Face::Front]);
m_rasterizer.set_material_state(SoftGPU::Face::Back, m_material_states[Face::Back]);
}
void SoftwareGLContext::sync_device_texcoord_config()