RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-19 20:45:08 +00:00
Code Issues Activity Actions

LibWeb: Make XMLSerializer GC-allocated

Browse source
This commit is contained in:
Andreas Kling 2022-09-03 00:22:54 +02:00
parent 6b7a1d13e9
commit 233208b640
4 changed files with 21 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibWeb/DOMParsing/XMLSerializer.cpp
View file

@ -4,6 +4,7 @@
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
#include <LibWeb/Bindings/XMLSerializerPrototype.h>
#include <LibWeb/DOM/CDATASection.h> #include <LibWeb/DOM/CDATASection.h>
#include <LibWeb/DOM/Comment.h> #include <LibWeb/DOM/Comment.h>
#include <LibWeb/DOM/Document.h> #include <LibWeb/DOM/Document.h>
@ -20,7 +21,17 @@
namespace Web::DOMParsing { namespace Web::DOMParsing {
XMLSerializer::XMLSerializer() = default; JS::NonnullGCPtr<XMLSerializer> XMLSerializer::create_with_global_object(HTML::Window& window)
{
return *window.heap().allocate<XMLSerializer>(window.realm(), window);
}
XMLSerializer::XMLSerializer(HTML::Window& window)
: PlatformObject(window.realm())
{
set_prototype(&window.ensure_web_prototype<Bindings::XMLSerializerPrototype>("XMLSerializer"));
}
XMLSerializer::~XMLSerializer() = default; XMLSerializer::~XMLSerializer() = default;
// https://w3c.github.io/DOM-Parsing/#dom-xmlserializer-serializetostring // https://w3c.github.io/DOM-Parsing/#dom-xmlserializer-serializetostring

21
Userland/Libraries/LibWeb/DOMParsing/XMLSerializer.h
View file

@ -6,29 +6,22 @@
#pragma once #pragma once
#include <AK/RefCounted.h> #include <LibWeb/Bindings/PlatformObject.h>
#include <LibWeb/Bindings/Wrappable.h>
#include <LibWeb/Forward.h>
namespace Web::DOMParsing { namespace Web::DOMParsing {
class XMLSerializer final class XMLSerializer final : public Bindings::PlatformObject {
: public RefCounted<XMLSerializer> WEB_PLATFORM_OBJECT(XMLSerializer, Bindings::PlatformObject);
, public Bindings::Wrappable {
public:
using WrapperType = Bindings::XMLSerializerWrapper;
static NonnullRefPtr<XMLSerializer> create_with_global_object(HTML::Window&) public:
{ static JS::NonnullGCPtr<XMLSerializer> create_with_global_object(HTML::Window&);
return adopt_ref(*new XMLSerializer());
}
virtual ~XMLSerializer() override; virtual ~XMLSerializer() override;
DOM::ExceptionOr<String> serialize_to_string(JS::NonnullGCPtr<DOM::Node> root); DOM::ExceptionOr<String> serialize_to_string(JS::NonnullGCPtr<DOM::Node> root);
private: private:
XMLSerializer(); explicit XMLSerializer(HTML::Window&);
}; };
enum class RequireWellFormed { enum class RequireWellFormed {
@ -39,3 +32,5 @@ enum class RequireWellFormed {
DOM::ExceptionOr<String> serialize_node_to_xml_string(JS::NonnullGCPtr<DOM::Node> root, RequireWellFormed require_well_formed); DOM::ExceptionOr<String> serialize_node_to_xml_string(JS::NonnullGCPtr<DOM::Node> root, RequireWellFormed require_well_formed);
} }
WRAPPER_HACK(XMLSerializer, Web::DOMParsing)

1
Userland/Libraries/LibWeb/Forward.h
View file

@ -479,7 +479,6 @@ class WorkerNavigatorWrapper;
class Wrappable; class Wrappable;
class Wrapper; class Wrapper;
class XMLHttpRequestPrototype; class XMLHttpRequestPrototype;
class XMLSerializerWrapper;
enum class CanPlayTypeResult; enum class CanPlayTypeResult;
enum class CanvasFillRule; enum class CanvasFillRule;
enum class EndingType; enum class EndingType;

2
Userland/Libraries/LibWeb/idl_files.cmake
View file

@ -50,7 +50,7 @@ libweb_js_wrapper(DOM/ShadowRoot NO_INSTANCE)
libweb_js_wrapper(DOM/StaticRange NO_INSTANCE) libweb_js_wrapper(DOM/StaticRange NO_INSTANCE)
libweb_js_wrapper(DOM/Text NO_INSTANCE) libweb_js_wrapper(DOM/Text NO_INSTANCE)
libweb_js_wrapper(DOM/TreeWalker NO_INSTANCE) libweb_js_wrapper(DOM/TreeWalker NO_INSTANCE)
libweb_js_wrapper(DOMParsing/XMLSerializer) libweb_js_wrapper(DOMParsing/XMLSerializer NO_INSTANCE)
libweb_js_wrapper(Encoding/TextDecoder) libweb_js_wrapper(Encoding/TextDecoder)
libweb_js_wrapper(Encoding/TextEncoder) libweb_js_wrapper(Encoding/TextEncoder)
libweb_js_wrapper(Fetch/Headers ITERABLE) libweb_js_wrapper(Fetch/Headers ITERABLE)