RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:07:45 +00:00
Code Issues Activity Actions

LibWeb: Update layout in HTMLElement.offset{Top,Left}

Browse source 
We can't report layout-dependent metrics without first ensuring that
layout is up-to-date.
This commit is contained in:
Andreas Kling 2022-09-17 16:10:08 +02:00
parent 9e274d9501
commit 2371446952
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/HTMLElement.cpp
View file

@ -141,6 +141,9 @@ String HTMLElement::inner_text()
// // https://drafts.csswg.org/cssom-view/#dom-htmlelement-offsettop // // https://drafts.csswg.org/cssom-view/#dom-htmlelement-offsettop
int HTMLElement::offset_top() const int HTMLElement::offset_top() const
{ {
// NOTE: Ensure that layout is up-to-date before looking at metrics.
const_cast<DOM::Document&>(document()).update_layout();
if (is<HTML::HTMLBodyElement>(this) || !layout_node() || !parent_element() || !parent_element()->layout_node()) if (is<HTML::HTMLBodyElement>(this) || !layout_node() || !parent_element() || !parent_element()->layout_node())
return 0; return 0;
auto position = layout_node()->box_type_agnostic_position(); auto position = layout_node()->box_type_agnostic_position();
@ -151,6 +154,9 @@ int HTMLElement::offset_top() const
// https://drafts.csswg.org/cssom-view/#dom-htmlelement-offsetleft // https://drafts.csswg.org/cssom-view/#dom-htmlelement-offsetleft
int HTMLElement::offset_left() const int HTMLElement::offset_left() const
{ {
// NOTE: Ensure that layout is up-to-date before looking at metrics.
const_cast<DOM::Document&>(document()).update_layout();
if (is<HTML::HTMLBodyElement>(this) || !layout_node() || !parent_element() || !parent_element()->layout_node()) if (is<HTML::HTMLBodyElement>(this) || !layout_node() || !parent_element() || !parent_element()->layout_node())
return 0; return 0;
auto position = layout_node()->box_type_agnostic_position(); auto position = layout_node()->box_type_agnostic_position();