RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:07:35 +00:00
Code Issues Activity Actions

LibGUI: Rename ModelSelection::remove_matching => remove_all_matching

Browse source 
Let's be consistent with how Vector, HashTable and HashMap names these.
This commit is contained in:
Andreas Kling 2022-01-05 17:03:49 +01:00
parent c6bcd0dfe4
commit 2375e1bcda
4 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/AbstractView.cpp
View file

@ -71,7 +71,7 @@ void AbstractView::model_did_update(unsigned int flags)
m_cursor_index = {}; m_cursor_index = {};
if (!model()->is_within_range(m_drop_candidate_index)) if (!model()->is_within_range(m_drop_candidate_index))
m_drop_candidate_index = {}; m_drop_candidate_index = {};
selection().remove_matching([this](auto& index) { return !model()->is_within_range(index); }); selection().remove_all_matching([this](auto& index) { return !model()->is_within_range(index); });
auto index = find_next_search_match(m_highlighted_search.view()); auto index = find_next_search_match(m_highlighted_search.view());
if (index.is_valid()) if (index.is_valid())

2
Userland/Libraries/LibGUI/FileSystemModel.cpp
View file

@ -423,7 +423,7 @@ void FileSystemModel::handle_file_event(Core::FileWatcherEvent const& event)
end_delete_rows(); end_delete_rows();
for_each_view([&](AbstractView& view) { for_each_view([&](AbstractView& view) {
view.selection().remove_matching([&](auto& selection_index) { view.selection().remove_all_matching([&](auto& selection_index) {
return selection_index.internal_data() == index.internal_data(); return selection_index.internal_data() == index.internal_data();
}); });
if (view.cursor_index().internal_data() == index.internal_data()) { if (view.cursor_index().internal_data() == index.internal_data()) {

2
Userland/Libraries/LibGUI/ModelSelection.cpp
View file

@ -10,7 +10,7 @@
namespace GUI { namespace GUI {
void ModelSelection::remove_matching(Function<bool(const ModelIndex&)> filter) void ModelSelection::remove_all_matching(Function<bool(ModelIndex const&)> filter)
{ {
if (m_indices.remove_all_matching([&](ModelIndex const& index) { return filter(index); })) if (m_indices.remove_all_matching([&](ModelIndex const& index) { return filter(index); }))
notify_selection_changed(); notify_selection_changed();

2
Userland/Libraries/LibGUI/ModelSelection.h
View file

@ -76,7 +76,7 @@ public:
return *m_indices.begin(); return *m_indices.begin();
} }
void remove_matching(Function<bool(const ModelIndex&)>); void remove_all_matching(Function<bool(ModelIndex const&)> filter);
template<typename Function> template<typename Function>
void change_from_model(Badge<SortingProxyModel>, Function f) void change_from_model(Badge<SortingProxyModel>, Function f)