RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 18:05:07 +00:00
Code Issues Activity Actions

Browser+LibWeb+WebContent: Parse cookies in the OOP tab

Browse source 
To protect the main Browser process against nefarious cookies, parse the
cookies out-of-process and then send the parsed result over IPC to the
main process. This way, if the cookie parser blows up, only that tab
will be affected.
This commit is contained in:
Timothy Flynn 2021-04-15 10:36:20 -04:00 • committed by Andreas Kling
parent 6e10c2cdb7
commit 2381b19719
19 changed files with 79 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/InProcessWebView.cpp
View file

@ -440,7 +440,7 @@ String InProcessWebView::page_did_request_cookie(const URL& url, Cookie::Source
return {};
}
void InProcessWebView::page_did_set_cookie(const URL& url, const String& cookie, Cookie::Source source)
void InProcessWebView::page_did_set_cookie(const URL& url, const Cookie::ParsedCookie& cookie, Cookie::Source source)
{
if (on_set_cookie)
on_set_cookie(url, cookie, source);