RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:04:59 +00:00
Code Issues Activity Actions

LibCore+Userland: Remove ArgsParser::add*(Vector<char const*>&)

Browse source 
This finally makes ArgsParser's value API free of silly char*'s!
This commit is contained in:
Ali Mohammad Pur 2023-03-01 00:31:46 +03:30 • committed by Andreas Kling
parent 500044906d
commit 23c514cda3
5 changed files with 31 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Userland/Utilities/seq.cpp
View file

@ -27,20 +27,21 @@ static void print_usage(FILE* stream)
fputs(g_usage, stream);
}
static double get_double(char const* name, char const* d_string, size_t* number_of_decimals)
static double get_double(char const* name, StringView d_string, size_t* number_of_decimals)
{
char* end;
double d = strtod(d_string, &end);
if (d == 0 && end == d_string) {
auto d = d_string.to_double();
if (!d.has_value()) {
warnln("{}: invalid argument \"{}\"", name, d_string);
print_usage(stderr);
exit(1);
}
if (char const* dot = strchr(d_string, '.'))
*number_of_decimals = strlen(dot + 1);
if (auto dot = d_string.find('.'); dot.has_value())
*number_of_decimals = d_string.length() - *dot - 1;
else
*number_of_decimals = 0;
return d;
return *d;
}
ErrorOr<int> serenity_main(Main::Arguments arguments)
@ -50,7 +51,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
StringView separator = "\n"sv;
StringView terminator = ""sv;
Vector<char const*> parameters;
Vector<StringView> parameters;
Core::ArgsParser args_parser;
args_parser.add_option(separator, "Characters to print after each number (default: \\n)", "separator", 's', "separator");