1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:57:45 +00:00

LibJS: Implement Temporal.Duration.prototype.weeks

This commit is contained in:
Linus Groh 2021-07-15 23:43:55 +01:00
parent 8011409428
commit 23d0c3494f
4 changed files with 30 additions and 0 deletions

View file

@ -353,6 +353,7 @@ namespace JS {
P(valueOf) \ P(valueOf) \
P(values) \ P(values) \
P(warn) \ P(warn) \
P(weeks) \
P(writable) \ P(writable) \
P(years) P(years)

View file

@ -27,6 +27,7 @@ void DurationPrototype::initialize(GlobalObject& global_object)
define_native_accessor(vm.names.years, years_getter, {}, Attribute::Configurable); define_native_accessor(vm.names.years, years_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.months, months_getter, {}, Attribute::Configurable); define_native_accessor(vm.names.months, months_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.weeks, weeks_getter, {}, Attribute::Configurable);
} }
static Duration* typed_this(GlobalObject& global_object) static Duration* typed_this(GlobalObject& global_object)
@ -68,4 +69,17 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::months_getter)
return Value(duration->months()); return Value(duration->months());
} }
// 7.3.5 get Temporal.Duration.prototype.weeks, https://tc39.es/proposal-temporal/#sec-get-temporal.duration.prototype.weeks
JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::weeks_getter)
{
// 1. Let duration be the this value.
// 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
auto* duration = typed_this(global_object);
if (vm.exception())
return {};
// 3. Return duration.[[Weeks]].
return Value(duration->weeks());
}
} }

View file

@ -21,6 +21,7 @@ public:
private: private:
JS_DECLARE_NATIVE_FUNCTION(years_getter); JS_DECLARE_NATIVE_FUNCTION(years_getter);
JS_DECLARE_NATIVE_FUNCTION(months_getter); JS_DECLARE_NATIVE_FUNCTION(months_getter);
JS_DECLARE_NATIVE_FUNCTION(weeks_getter);
}; };
} }

View file

@ -0,0 +1,14 @@
describe("correct behavior", () => {
test("basic functionality", () => {
const duration = new Temporal.Duration(0, 0, 123);
expect(duration.weeks).toBe(123);
});
});
test("errors", () => {
test("this value must be a Temporal.Duration object", () => {
expect(() => {
Reflect.get(Temporal.Duration.prototype, "weeks", "foo");
}).toThrowWithMessage(TypeError, "Not a Temporal.Duration");
});
});