RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 19:38:12 +00:00
Code Issues Activity Actions

LibIPC: Support sending file descriptors :^)

Browse source 
It is now possible to use the special IPC::File type in message arguments. In
C++, the type is nothing more than a wrapper over a file descriptor. But when
serializing/deserializing IPC::File arguments, LibIPC will use the sendfd/recvfd
kernel APIs instead of sending the integer inline.

This makes it quite convenient to pass files over IPC, and will allow us to
significantly tighten sandboxes in the future :^)

Closes https://github.com/SerenityOS/serenity/issues/3643
This commit is contained in:
Sergey Bugaev 2020-11-21 21:59:12 +03:00 • committed by Andreas Kling
parent fa2e3e2be4
commit 23dc3ff0c2
9 changed files with 148 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

83
Libraries/LibIPC/Encoder.cpp
View file

@ -29,6 +29,7 @@
#include <AK/URL.h>
#include <LibIPC/Dictionary.h>
#include <LibIPC/Encoder.h>
#include <LibIPC/File.h>
namespace IPC {
@ -39,77 +40,77 @@ Encoder& Encoder::operator<<(bool value)
Encoder& Encoder::operator<<(u8 value)
{
m_buffer.append(value);
m_buffer.data.append(value);
return *this;
}
Encoder& Encoder::operator<<(u16 value)
{
m_buffer.ensure_capacity(m_buffer.size() + 2);
m_buffer.unchecked_append((u8)value);
m_buffer.unchecked_append((u8)(value >> 8));
m_buffer.data.ensure_capacity(m_buffer.data.size() + 2);
m_buffer.data.unchecked_append((u8)value);
m_buffer.data.unchecked_append((u8)(value >> 8));
return *this;
}
Encoder& Encoder::operator<<(u32 value)
{
m_buffer.ensure_capacity(m_buffer.size() + 4);
m_buffer.unchecked_append((u8)value);
m_buffer.unchecked_append((u8)(value >> 8));
m_buffer.unchecked_append((u8)(value >> 16));
m_buffer.unchecked_append((u8)(value >> 24));
m_buffer.data.ensure_capacity(m_buffer.data.size() + 4);
m_buffer.data.unchecked_append((u8)value);
m_buffer.data.unchecked_append((u8)(value >> 8));
m_buffer.data.unchecked_append((u8)(value >> 16));
m_buffer.data.unchecked_append((u8)(value >> 24));
return *this;
}
Encoder& Encoder::operator<<(u64 value)
{
m_buffer.ensure_capacity(m_buffer.size() + 8);
m_buffer.unchecked_append((u8)value);
m_buffer.unchecked_append((u8)(value >> 8));
m_buffer.unchecked_append((u8)(value >> 16));
m_buffer.unchecked_append((u8)(value >> 24));
m_buffer.unchecked_append((u8)(value >> 32));
m_buffer.unchecked_append((u8)(value >> 40));
m_buffer.unchecked_append((u8)(value >> 48));
m_buffer.unchecked_append((u8)(value >> 56));
m_buffer.data.ensure_capacity(m_buffer.data.size() + 8);
m_buffer.data.unchecked_append((u8)value);
m_buffer.data.unchecked_append((u8)(value >> 8));
m_buffer.data.unchecked_append((u8)(value >> 16));
m_buffer.data.unchecked_append((u8)(value >> 24));
m_buffer.data.unchecked_append((u8)(value >> 32));
m_buffer.data.unchecked_append((u8)(value >> 40));
m_buffer.data.unchecked_append((u8)(value >> 48));
m_buffer.data.unchecked_append((u8)(value >> 56));
return *this;
}
Encoder& Encoder::operator<<(i8 value)
{
m_buffer.append((u8)value);
m_buffer.data.append((u8)value);
return *this;
}
Encoder& Encoder::operator<<(i16 value)
{
m_buffer.ensure_capacity(m_buffer.size() + 2);
m_buffer.unchecked_append((u8)value);
m_buffer.unchecked_append((u8)(value >> 8));
m_buffer.data.ensure_capacity(m_buffer.data.size() + 2);
m_buffer.data.unchecked_append((u8)value);
m_buffer.data.unchecked_append((u8)(value >> 8));
return *this;
}
Encoder& Encoder::operator<<(i32 value)
{
m_buffer.ensure_capacity(m_buffer.size() + 4);
m_buffer.unchecked_append((u8)value);
m_buffer.unchecked_append((u8)(value >> 8));
m_buffer.unchecked_append((u8)(value >> 16));
m_buffer.unchecked_append((u8)(value >> 24));
m_buffer.data.ensure_capacity(m_buffer.data.size() + 4);
m_buffer.data.unchecked_append((u8)value);
m_buffer.data.unchecked_append((u8)(value >> 8));
m_buffer.data.unchecked_append((u8)(value >> 16));
m_buffer.data.unchecked_append((u8)(value >> 24));
return *this;
}
Encoder& Encoder::operator<<(i64 value)
{
m_buffer.ensure_capacity(m_buffer.size() + 8);
m_buffer.unchecked_append((u8)value);
m_buffer.unchecked_append((u8)(value >> 8));
m_buffer.unchecked_append((u8)(value >> 16));
m_buffer.unchecked_append((u8)(value >> 24));
m_buffer.unchecked_append((u8)(value >> 32));
m_buffer.unchecked_append((u8)(value >> 40));
m_buffer.unchecked_append((u8)(value >> 48));
m_buffer.unchecked_append((u8)(value >> 56));
m_buffer.data.ensure_capacity(m_buffer.data.size() + 8);
m_buffer.data.unchecked_append((u8)value);
m_buffer.data.unchecked_append((u8)(value >> 8));
m_buffer.data.unchecked_append((u8)(value >> 16));
m_buffer.data.unchecked_append((u8)(value >> 24));
m_buffer.data.unchecked_append((u8)(value >> 32));
m_buffer.data.unchecked_append((u8)(value >> 40));
m_buffer.data.unchecked_append((u8)(value >> 48));
m_buffer.data.unchecked_append((u8)(value >> 56));
return *this;
}
@ -130,7 +131,7 @@ Encoder& Encoder::operator<<(const char* value)
Encoder& Encoder::operator<<(const StringView& value)
{
m_buffer.append((const u8*)value.characters_without_null_termination(), value.length());
m_buffer.data.append((const u8*)value.characters_without_null_termination(), value.length());
return *this;
}
@ -145,7 +146,7 @@ Encoder& Encoder::operator<<(const String& value)
Encoder& Encoder::operator<<(const ByteBuffer& value)
{
*this << static_cast<i32>(value.size());
m_buffer.append(value.data(), value.size());
m_buffer.data.append(value.data(), value.size());
return *this;
}
@ -163,4 +164,10 @@ Encoder& Encoder::operator<<(const Dictionary& dictionary)
return *this;
}
Encoder& Encoder::operator<<(const File& file)
{
m_buffer.fds.append(file.fd());
return *this;
}
}