RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:17:35 +00:00
Code Issues Activity Actions

BrowserSettings: Validate homepage URL

Browse source
This commit is contained in:
Julen Ruiz Aizpuru 2022-04-09 21:42:04 +02:00 • committed by Tim Flynn
parent af3174c9ce
commit 23ea5c6721
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Applications/BrowserSettings/BrowserSettingsWidget.cpp
View file

@ -9,6 +9,7 @@
#include <LibConfig/Client.h> #include <LibConfig/Client.h>
#include <LibGUI/JsonArrayModel.h> #include <LibGUI/JsonArrayModel.h>
#include <LibGUI/Label.h> #include <LibGUI/Label.h>
#include <LibGUI/MessageBox.h>
#include <LibGUI/Model.h> #include <LibGUI/Model.h>
static String default_homepage_url = "file:///res/html/misc/welcome.html"; static String default_homepage_url = "file:///res/html/misc/welcome.html";
@ -155,8 +156,14 @@ void BrowserSettingsWidget::set_search_engine_url(StringView url)
void BrowserSettingsWidget::apply_settings() void BrowserSettingsWidget::apply_settings()
{ {
// TODO: Ensure that the URL is valid, as we do in the BrowserWindow's change-homepage dialog auto homepage_url = m_homepage_url_textbox->text();
Config::write_string("Browser", "Preferences", "Home", m_homepage_url_textbox->text()); if (!URL(homepage_url).is_valid()) {
GUI::MessageBox::show_error(this->window(), "The homepage URL you have entered is not valid");
m_homepage_url_textbox->select_all();
m_homepage_url_textbox->set_focus(true);
return;
}
Config::write_string("Browser", "Preferences", "Home", homepage_url);
Config::write_bool("Browser", "Preferences", "ShowBookmarksBar", m_show_bookmarks_bar_checkbox->is_checked()); Config::write_bool("Browser", "Preferences", "ShowBookmarksBar", m_show_bookmarks_bar_checkbox->is_checked());