From 23febb9d8e035948c4443da5bb4075764b07aa6e Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Wed, 23 Dec 2020 14:55:24 +0100 Subject: [PATCH] Kernel: Ptrace::handle_syscall() should return errors as KResult --- Kernel/Ptrace.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Kernel/Ptrace.cpp b/Kernel/Ptrace.cpp index 656e200606..6688d4f5fe 100644 --- a/Kernel/Ptrace.cpp +++ b/Kernel/Ptrace.cpp @@ -128,27 +128,27 @@ KResultOr handle_syscall(const Kernel::Syscall::SC_ptrace_params& params, P case PT_PEEK: { Kernel::Syscall::SC_ptrace_peek_params peek_params; if (!copy_from_user(&peek_params, reinterpret_cast(params.addr))) - return -EFAULT; + return KResult(-EFAULT); if (!is_user_address(VirtualAddress { peek_params.address })) - return -EFAULT; + return KResult(-EFAULT); auto result = peer->process().peek_user_data(Userspace { (FlatPtr)peek_params.address }); if (result.is_error()) return result.error(); if (!copy_to_user(peek_params.out_data, &result.value())) - return -EFAULT; + return KResult(-EFAULT); break; } case PT_POKE: if (!is_user_address(VirtualAddress { params.addr })) - return -EFAULT; + return KResult(-EFAULT); return peer->process().poke_user_data(Userspace { (FlatPtr)params.addr }, params.data); default: - return -EINVAL; + return KResult(-EINVAL); } - return 0; + return KSuccess; } void copy_kernel_registers_into_ptrace_registers(PtraceRegisters& ptrace_regs, const RegisterState& kernel_regs)