RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 16:47:34 +00:00
Code Issues Activity Actions

LibWeb: Fix assertion failure when tokenizing JS regex literals

Browse source 
This fixes parsing the following regular expression: /</g;

It also adds a simple script element to the HTMLTokenizer regression
test, which also contains that specific regex.
This commit is contained in:
Max Wipfli 2021-07-15 01:25:34 +02:00 • committed by Andreas Kling
parent c82c652ee4
commit 2404ad6897
3 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/TestHTMLTokenizer.cpp
View file

@ -193,5 +193,5 @@ TEST_CASE(regression)
auto file_contents = file.value()->read_all();
auto tokens = run_tokenizer(file_contents);
u32 hash = hash_tokens(tokens);
EXPECT_EQ(hash, 2891738465u);
EXPECT_EQ(hash, 2203864459u);
}

7
Tests/LibWeb/tokenizer-test.html
View file

@ -3,6 +3,13 @@
<head>
<meta charset="UTF-8">
<title>This is a test page :^)</title>
<script>
let foo = 2;
var bar = 3;
if (foo < bar)
alert("Check happens with HTML special <characters>.");
let regex = /</g;
</script>
</head>
<body>
<p>This is the first paragraph.</p>