RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:47:34 +00:00
Code Issues Activity Actions

LibWeb: Treat invalid StyleValues that included var() as unset

Browse source 
This means StyleComputer::resolve_unresolved_style_value() always
returns a value, so we can change its return type.

However, it does still return an UnresolvedStyleValue sometimes, so we
can't remove those checks from the user code.
This commit is contained in:
Sam Atkins 2023-08-26 12:08:07 +01:00 • committed by Sam Atkins
parent 6b66e80fb8
commit 240ec9aeed
5 changed files with 28 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Tests/LibWeb/Ref/css-invalid-var-ref.html Normal file
View file

@ -0,0 +1,5 @@
<!doctype html><style>
div {
color: black;
}
</style><div>This text should be black.

6
Tests/LibWeb/Ref/css-invalid-var.html Normal file
View file

@ -0,0 +1,6 @@
<!doctype html><style>
div {
color: red;
color: var(--wat);
}
</style><div>This text should be black.

1
Tests/LibWeb/Ref/manifest.json
View file

@ -3,6 +3,7 @@
"css-any-link-selector.html": "css-any-link-selector-ref.html",
"css-gradient-currentcolor.html": "css-gradient-currentcolor-ref.html",
"css-gradients.html": "css-gradients-ref.html",
"css-invalid-var.html": "css-invalid-var-ref.html",
"css-lang-selector.html": "css-lang-selector-ref.html",
"css-local-link-selector.html": "css-local-link-selector-ref.html",
"css-placeholder-shown-selector.html": "css-placeholder-shown-selector-ref.html",