From 24207d3795c41b0a38c99f14ecff7fda5b32662e Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Wed, 15 Sep 2021 23:50:46 -0700 Subject: [PATCH] Kernel: Fetch range once for each iteration of find_regions_intersecting pvs-studio flagged this as a potential optimization. --- Kernel/Memory/AddressSpace.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Kernel/Memory/AddressSpace.cpp b/Kernel/Memory/AddressSpace.cpp index 22f7028cd0..5579517910 100644 --- a/Kernel/Memory/AddressSpace.cpp +++ b/Kernel/Memory/AddressSpace.cpp @@ -251,10 +251,11 @@ Vector AddressSpace::find_regions_intersecting(VirtualRange const& rang if (!found_region) return regions; for (auto iter = m_regions.begin_from((*found_region)->vaddr().get()); !iter.is_end(); ++iter) { - if ((*iter)->range().base() < range.end() && (*iter)->range().end() > range.base()) { + const auto& iter_range = (*iter)->range(); + if (iter_range.base() < range.end() && iter_range.end() > range.base()) { regions.append(*iter); - total_size_collected += (*iter)->size() - (*iter)->range().intersect(range).size(); + total_size_collected += (*iter)->size() - iter_range.intersect(range).size(); if (total_size_collected == range.size()) break; }