From 2434d34644b7470956a46b36905d36c079399148 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Wed, 9 Mar 2022 22:06:19 +0100 Subject: [PATCH] =?UTF-8?q?LibJS/Tests:=20Add=20tests=20for=20'=E2=88=9200?= =?UTF-8?q?0000'=20(U+2212)=20DateExtendedYear?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I noticed we only have coverage for this with the ASCII minus sign in our own test suite. --- .../LibJS/Tests/builtins/Temporal/PlainDate/PlainDate.from.js | 3 +++ .../builtins/Temporal/PlainDateTime/PlainDateTime.from.js | 3 +++ .../builtins/Temporal/PlainMonthDay/PlainMonthDay.from.js | 3 +++ .../LibJS/Tests/builtins/Temporal/PlainTime/PlainTime.from.js | 3 +++ .../builtins/Temporal/PlainYearMonth/PlainYearMonth.from.js | 3 +++ 5 files changed, 15 insertions(+) diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDate/PlainDate.from.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDate/PlainDate.from.js index d5e14a4c9b..5a52b58e2c 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDate/PlainDate.from.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDate/PlainDate.from.js @@ -54,5 +54,8 @@ describe("errors", () => { expect(() => { Temporal.PlainDate.from("-000000-01-01"); }).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero"); + expect(() => { + Temporal.PlainDate.from("−000000-01-01"); // U+2212 + }).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero"); }); }); diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.from.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.from.js index e741713249..66cea37352 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.from.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.from.js @@ -191,5 +191,8 @@ describe("errors", () => { expect(() => { Temporal.PlainDateTime.from("-000000-01-01"); }).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero"); + expect(() => { + Temporal.PlainDateTime.from("−000000-01-01"); // U+2212 + }).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero"); }); }); diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainMonthDay/PlainMonthDay.from.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainMonthDay/PlainMonthDay.from.js index ffffb51b8f..bedcd2952e 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainMonthDay/PlainMonthDay.from.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainMonthDay/PlainMonthDay.from.js @@ -80,5 +80,8 @@ describe("errors", () => { expect(() => { Temporal.PlainMonthDay.from("-000000-01-01"); }).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero"); + expect(() => { + Temporal.PlainMonthDay.from("−000000-01-01"); // U+2212 + }).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero"); }); }); diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainTime/PlainTime.from.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainTime/PlainTime.from.js index afacf2096b..d223b2f07e 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainTime/PlainTime.from.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainTime/PlainTime.from.js @@ -69,6 +69,9 @@ describe("errors", () => { expect(() => { Temporal.PlainTime.from("-000000-01-01T00:00:00"); }).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero"); + expect(() => { + Temporal.PlainTime.from("−000000-01-01T00:00:00"); // U+2212 + }).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero"); }); test("ambiguous string must contain a time designator", () => { diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainYearMonth/PlainYearMonth.from.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainYearMonth/PlainYearMonth.from.js index 5579e22244..62348189e2 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainYearMonth/PlainYearMonth.from.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainYearMonth/PlainYearMonth.from.js @@ -106,5 +106,8 @@ describe("errors", () => { expect(() => { Temporal.PlainYearMonth.from("-000000-01"); }).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero"); + expect(() => { + Temporal.PlainYearMonth.from("−000000-01-01"); // U+2212 + }).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero"); }); });