RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:58:11 +00:00
Code Issues Activity Actions

LibWeb: Align session history step application code with latest spec

Browse source 
Replaces direct "apply the history step" calls with new functions from
the spec:
- "update for navigable creation/destruction"
- "apply the push/replace history step"
- "apply the reload history step"
This commit is contained in:
Aliaksandr Kalenik 2023-09-03 22:20:32 +02:00 • committed by Andreas Kling
parent d3d2e56a68
commit 2445205e9d
4 changed files with 39 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/NavigableContainer.cpp
View file

@ -126,7 +126,8 @@ WebIDL::ExceptionOr<void> NavigableContainer::create_new_child_navigable()
// 5. Append nestedHistory to parentDocState's nested histories.
parent_doc_state->nested_histories().append(move(nested_history));
// FIXME: 6. Update for navigable creation/destruction given traversable
// 6. Update for navigable creation/destruction given traversable
traversable->update_for_navigable_creation_or_destruction();
});
return {};
@ -336,7 +337,7 @@ void NavigableContainer::destroy_the_child_navigable()
// 8. Append the following session history traversal steps to traversable:
traversable->append_session_history_traversal_steps([traversable] {
// 1. Apply pending history changes to traversable.
traversable->apply_pending_history_changes();
traversable->update_for_navigable_creation_or_destruction();
});
}