RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:37:35 +00:00
Code Issues Activity Actions

LibGUI: Guard against use-after-free in Clipboard::the()

Browse source 
We now make sure that a VERIFY will fail if Clipboard::the() is called
after the destruction of its static-local variables.
This commit is contained in:
Itamar 2022-02-18 17:21:58 +02:00 • committed by Andreas Kling
parent 4d2357f8f3
commit 246b42b635
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibGUI/Clipboard.cpp
View file

@ -44,6 +44,12 @@ void Clipboard::initialize(Badge<Application>)
Clipboard& Clipboard::the()
{
static bool s_destructed = false;
static ScopeGuard destructed_guard([] {
s_destructed = true;
});
VERIFY(!s_destructed); // Catch use-after-free
static Clipboard s_the;
return s_the;
}