RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:07:44 +00:00
Code Issues Activity Actions

LibJS: Only allow Calendar this value in Temporal.Calendar.prototype.id

Browse source 
This is a normative change in the Temporal spec.

See: 2644fc6
This commit is contained in:
Linus Groh 2021-12-18 17:07:14 +00:00
parent 1f7c196788
commit 247d2f7cc4
2 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibJS/Runtime/Temporal/CalendarPrototype.cpp
View file

@ -66,10 +66,11 @@ void CalendarPrototype::initialize(GlobalObject& global_object)
JS_DEFINE_NATIVE_FUNCTION(CalendarPrototype::id_getter) JS_DEFINE_NATIVE_FUNCTION(CalendarPrototype::id_getter)
{ {
// 1. Let calendar be the this value. // 1. Let calendar be the this value.
auto calendar = vm.this_value(global_object); // 2. Perform ? RequireInternalSlot(calendar, [[InitializedTemporalCalendar]]).
auto* calendar = TRY(typed_this_object(global_object));
// 2. Return ? ToString(calendar). // 3. Return ? ToString(calendar).
return { js_string(vm, TRY(calendar.to_string(global_object))) }; return { js_string(vm, TRY(Value(calendar).to_string(global_object))) };
} }
// 12.4.4 Temporal.Calendar.prototype.dateFromFields ( fields [ , options ] ), https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.datefromfields // 12.4.4 Temporal.Calendar.prototype.dateFromFields ( fields [ , options ] ), https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.datefromfields

8
Userland/Libraries/LibJS/Tests/builtins/Temporal/Calendar/Calendar.prototype.id.js
View file

@ -3,8 +3,12 @@ describe("correct behavior", () => {
const calendar = new Temporal.Calendar("iso8601"); const calendar = new Temporal.Calendar("iso8601");
expect(calendar.id).toBe("iso8601"); expect(calendar.id).toBe("iso8601");
}); });
});
test("works with any this value", () => { describe("errors", () => {
expect(Reflect.get(Temporal.Calendar.prototype, "id", "foo")).toBe("foo"); test("this value must be a Temporal.Calendar object", () => {
expect(() => {
Reflect.get(Temporal.Calendar.prototype, "id", "foo");
}).toThrowWithMessage(TypeError, "Not an object of type Temporal.Calendar");
}); });
}); });