From 2485c500a3589f4cead214598d0138d76dc5f454 Mon Sep 17 00:00:00 2001 From: Rodrigo Tobar Date: Fri, 6 Jan 2023 00:31:53 +0800 Subject: [PATCH] LibPDF: Fix Destination formatting This was not correctly written, and thus printed confusing output. --- Userland/Libraries/LibPDF/Document.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibPDF/Document.h b/Userland/Libraries/LibPDF/Document.h index d2d54949ed..d58598e2b3 100644 --- a/Userland/Libraries/LibPDF/Document.h +++ b/Userland/Libraries/LibPDF/Document.h @@ -227,16 +227,16 @@ struct Formatter : Formatter { } StringBuilder param_builder; - TRY(Formatter::format(builder, "{{ type={} page="sv, type_str)); - if (destination.page.has_value()) - TRY(builder.put_literal("{}"sv)); + builder.builder().appendff("{{ type={} page="sv, type_str); + if (!destination.page.has_value()) + TRY(builder.put_literal("{{}}"sv)); else TRY(builder.put_u64(destination.page.value())); for (auto& param : destination.parameters) { TRY(builder.put_f64(double(param))); TRY(builder.put_literal(" "sv)); } - return builder.put_literal("}}"sv); + return builder.put_literal(" }}"sv); } };