RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:48:11 +00:00
Code Issues Activity Actions

LibJS: Support o.f++ :^)

Browse source 
This patch teaches UpdateExpression how to use a Reference. Some other
changes were necessary to keep tests working:
A Reference can now also refer to a local or global variable. This is
not fully aligned with the spec since we don't have a Record concept.
This commit is contained in:
Andreas Kling 2020-04-28 14:44:48 +02:00
parent ee0bf55127
commit 24cce3674b
5 changed files with 101 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Libraries/LibJS/AST.cpp
View file

@ -411,6 +411,8 @@ Value UnaryExpression::execute(Interpreter& interpreter) const
return Value(true);
// FIXME: Support deleting locals
ASSERT(!reference.is_local_variable());
if (reference.is_global_variable())
return interpreter.global_object().delete_property(reference.name());
auto* base_object = reference.base().to_object(interpreter.heap());
if (!base_object)
return {};
@ -844,7 +846,7 @@ Value AssignmentExpression::execute(Interpreter& interpreter) const
if (reference.is_unresolvable())
return interpreter.throw_exception<ReferenceError>("Invalid left-hand side in assignment");
reference.assign(interpreter, rhs_result);
reference.put(interpreter, rhs_result);
if (interpreter.exception())
return {};
@ -853,9 +855,11 @@ Value AssignmentExpression::execute(Interpreter& interpreter) const
Value UpdateExpression::execute(Interpreter& interpreter) const
{
ASSERT(m_argument->is_identifier());
auto name = static_cast<const Identifier&>(*m_argument).string();
auto old_value = m_argument->execute(interpreter);
auto reference = m_argument->to_reference(interpreter);
if (interpreter.exception())
return {};
auto old_value = reference.get(interpreter);
if (interpreter.exception())
return {};
old_value = old_value.to_number();
@ -873,7 +877,9 @@ Value UpdateExpression::execute(Interpreter& interpreter) const
}
auto new_value = Value(old_value.as_double() + op_result);
interpreter.set_variable(name, new_value);
reference.put(interpreter, new_value);
if (interpreter.exception())
return {};
return m_prefixed ? new_value : old_value;
}