RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 02:17:35 +00:00
Code Issues Activity Actions

WebDriver: Move GET /session/{session id}/window impl into Session

Browse source
This commit is contained in:
Linus Groh 2022-10-19 19:39:54 +02:00
parent 0064d2e8c8
commit 24ee5a2202
3 changed files with 16 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Services/WebDriver/Client.cpp
View file

@ -533,13 +533,9 @@ ErrorOr<JsonValue, HttpError> Client::handle_get_window_handle(Vector<StringView
dbgln_if(WEBDRIVER_DEBUG, "Handling GET /session/<session_id>/window");
auto* session = TRY(find_session_with_id(parameters[0]));
// 1. If the current top-level browsing context is no longer open, return error with error code no such window.
auto current_window = session->get_window_object();
if (!current_window.has_value())
return HttpError { 404, "no such window", "Window not found" };
// 2. Return success with data being the window handle associated with the current top-level browsing context.
return make_json_value(session->current_window_handle());
// NOTE: Spec steps handled in Session::get_title().
auto result = TRY(session->get_window_handle());
return make_json_value(result);
}
// 11.2 Close Window, https://w3c.github.io/webdriver/#dfn-close-window