RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:27:35 +00:00
Code Issues Activity Actions

LibWeb: Make factory method of DOM::DOMTokenList fallible

Browse source
This commit is contained in:
Kenneth Myhra 2023-02-14 21:34:28 +01:00 • committed by Linus Groh
parent 1e03aa0ece
commit 251c063897
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/DOMTokenList.cpp
View file

@ -52,10 +52,10 @@ inline void replace_in_ordered_set(Vector<DeprecatedString>& set, StringView ite
namespace Web::DOM { namespace Web::DOM {
DOMTokenList* DOMTokenList::create(Element const& associated_element, DeprecatedFlyString associated_attribute) WebIDL::ExceptionOr<JS::NonnullGCPtr<DOMTokenList>> DOMTokenList::create(Element const& associated_element, DeprecatedFlyString associated_attribute)
{ {
auto& realm = associated_element.realm(); auto& realm = associated_element.realm();
return realm.heap().allocate<DOMTokenList>(realm, associated_element, move(associated_attribute)).release_allocated_value_but_fixme_should_propagate_errors(); return MUST_OR_THROW_OOM(realm.heap().allocate<DOMTokenList>(realm, associated_element, move(associated_attribute)));
} }
// https://dom.spec.whatwg.org/#ref-for-domtokenlist%E2%91%A0%E2%91%A2 // https://dom.spec.whatwg.org/#ref-for-domtokenlist%E2%91%A0%E2%91%A2

2
Userland/Libraries/LibWeb/DOM/DOMTokenList.h
View file

@ -23,7 +23,7 @@ class DOMTokenList final : public Bindings::LegacyPlatformObject {
WEB_PLATFORM_OBJECT(DOMTokenList, Bindings::LegacyPlatformObject); WEB_PLATFORM_OBJECT(DOMTokenList, Bindings::LegacyPlatformObject);
public: public:
static DOMTokenList* create(Element const& associated_element, DeprecatedFlyString associated_attribute); static WebIDL::ExceptionOr<JS::NonnullGCPtr<DOMTokenList>> create(Element const& associated_element, DeprecatedFlyString associated_attribute);
~DOMTokenList() = default; ~DOMTokenList() = default;
void associated_attribute_changed(StringView value); void associated_attribute_changed(StringView value);

2
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -455,7 +455,7 @@ NonnullRefPtr<CSS::StyleProperties> Element::resolved_css_values()
DOMTokenList* Element::class_list() DOMTokenList* Element::class_list()
{ {
if (!m_class_list) if (!m_class_list)
m_class_list = DOMTokenList::create(*this, HTML::AttributeNames::class_); m_class_list = DOMTokenList::create(*this, HTML::AttributeNames::class_).release_value_but_fixme_should_propagate_errors();
return m_class_list; return m_class_list;
} }