RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:38:11 +00:00
Code Issues Activity Actions

LibSymbolication+SystemMonitor+bt: Move symbolication back in-process

Browse source 
Process-separated symbolication was cute, but ultimately the threat
model is kinda silly. We're already *running* the binary, but we're
afraid to parse its symbol table? :^)

This commit makes SystemMonitor and bt do symbolication in-process.
SymbolServer and the symbol user will be removed separately.
This commit is contained in:
Andreas Kling 2021-05-22 18:23:51 +02:00
parent d783076a30
commit 252cb54310
6 changed files with 60 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/SystemMonitor/ThreadStackWidget.cpp
View file

@ -45,7 +45,7 @@ void ThreadStackWidget::set_ids(pid_t pid, pid_t tid)
void ThreadStackWidget::refresh()
{
auto symbols = SymbolClient::symbolicate_thread(m_pid, m_tid);
auto symbols = Symbolication::symbolicate_thread(m_pid, m_tid);
StringBuilder builder;