RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:27:35 +00:00
Code Issues Activity Actions

LibSymbolication+SystemMonitor+bt: Move symbolication back in-process

Browse source 
Process-separated symbolication was cute, but ultimately the threat
model is kinda silly. We're already *running* the binary, but we're
afraid to parse its symbol table? :^)

This commit makes SystemMonitor and bt do symbolication in-process.
SymbolServer and the symbol user will be removed separately.
This commit is contained in:
Andreas Kling 2021-05-22 18:23:51 +02:00
parent d783076a30
commit 252cb54310
6 changed files with 60 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Userland/Libraries/LibSymbolication/Client.h
View file

@ -6,11 +6,9 @@
#pragma once
#include <LibIPC/ServerConnection.h>
#include <SymbolServer/SymbolClientEndpoint.h>
#include <SymbolServer/SymbolServerEndpoint.h>
#include <AK/String.h>
namespace SymbolClient {
namespace Symbolication {
struct Symbol {
FlatPtr address { 0 };
@ -21,21 +19,6 @@ struct Symbol {
};
Vector<Symbol> symbolicate_thread(pid_t pid, pid_t tid);
class Client
: public IPC::ServerConnection<SymbolClientEndpoint, SymbolServerEndpoint>
, public SymbolClientEndpoint {
C_OBJECT(Client);
public:
virtual void handshake() override;
Optional<Symbol> symbolicate(const String& path, FlatPtr address);
private:
Client();
virtual void dummy() override;
};
Optional<Symbol> symbolicate(String const& path, FlatPtr address);
}