RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:17:35 +00:00
Code Issues Activity Actions

LibSymbolication+SystemMonitor+bt: Move symbolication back in-process

Browse source 
Process-separated symbolication was cute, but ultimately the threat
model is kinda silly. We're already *running* the binary, but we're
afraid to parse its symbol table? :^)

This commit makes SystemMonitor and bt do symbolication in-process.
SymbolServer and the symbol user will be removed separately.
This commit is contained in:
Andreas Kling 2021-05-22 18:23:51 +02:00
parent d783076a30
commit 252cb54310
6 changed files with 60 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Userland/Utilities/bt.cpp
View file

@ -10,34 +10,14 @@
#include <LibCore/EventLoop.h>
#include <LibCore/File.h>
#include <LibSymbolication/Client.h>
#include <unistd.h>
int main(int argc, char** argv)
{
if (pledge("stdio rpath unix fattr", nullptr) < 0) {
if (pledge("stdio rpath", nullptr) < 0) {
perror("pledge");
return 1;
}
if (unveil("/proc", "r") < 0) {
perror("unveil");
return 1;
}
if (unveil("/tmp/portal/symbol", "rw") < 0) {
perror("unveil");
return 1;
}
if (unveil("/usr/src", "b") < 0) {
perror("unveil");
return 1;
}
if (unveil(nullptr, nullptr) < 0) {
perror("unveil");
return 1;
}
char hostname[256];
if (gethostname(hostname, sizeof(hostname)) < 0) {
perror("gethostname");
@ -48,7 +28,7 @@ int main(int argc, char** argv)
pid_t pid = 0;
args_parser.add_positional_argument(pid, "PID", "pid");
args_parser.parse(argc, argv);
Core::EventLoop loop;
Core::EventLoop loop(Core::EventLoop::MakeInspectable::No);
Core::DirIterator iterator(String::formatted("/proc/{}/stacks", pid), Core::DirIterator::SkipDots);
if (iterator.has_error()) {
@ -59,7 +39,7 @@ int main(int argc, char** argv)
while (iterator.has_next()) {
pid_t tid = iterator.next_path().to_int().value();
outln("tid: {}", tid);
auto symbols = SymbolClient::symbolicate_thread(pid, tid);
auto symbols = Symbolication::symbolicate_thread(pid, tid);
for (auto& symbol : symbols) {
out("{:p} ", symbol.address);
if (!symbol.name.is_empty())