RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:28:11 +00:00
Code Issues Activity Actions

LibWeb: Fail resource loads on HTTP 4xx or 5xx error

Browse source 
This fixes an issue on ACID3 where failing image loads with body content
would still get displayed.
This commit is contained in:
Andreas Kling 2022-03-08 17:44:22 +01:00
parent 7b3642d08c
commit 252ed8ad18
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp
View file

@ -221,11 +221,15 @@ void ResourceLoader::load(LoadRequest& request, Function<void(ReadonlyBytes, con
--m_pending_loads;
if (on_load_counter_change)
on_load_counter_change();
if (!success) {
auto http_load_failure_msg = "HTTP load failed"sv;
log_failure(request, http_load_failure_msg);
if (!success || (status_code.has_value() && *status_code >= 400 && *status_code <= 599)) {
StringBuilder error_builder;
if (status_code.has_value())
error_builder.appendff("Load failed: {}", *status_code);
else
error_builder.append("Load failed");
log_failure(request, error_builder.string_view());
if (error_callback)
error_callback(http_load_failure_msg, {});
error_callback(error_builder.to_string(), {});
return;
}
log_success(request);