RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:17:44 +00:00
Code Issues Activity Actions

LibJS+WebContent+js: Reimplement console.log() and friends to spec

Browse source 
This implements the Logger and Printer abstract operations defined in
the console spec, and stubs out the Formatter AO. These are then used
for the "output a categorized log message" functions.
This commit is contained in:
Sam Atkins 2021-12-10 12:26:25 +00:00 • committed by Andreas Kling
parent fd7163b125
commit 260836135a
5 changed files with 211 additions and 125 deletions
Download patch file Download diff file Expand all files Collapse all files

84
Userland/Services/WebContent/WebContentConsoleClient.cpp
View file

@ -115,56 +115,6 @@ void WebContentConsoleClient::send_messages(i32 start_index)
m_client.async_did_get_js_console_messages(start_index, message_types, messages);
}
JS::Value WebContentConsoleClient::log()
{
print_html(escape_html_entities(vm().join_arguments()));
return JS::js_undefined();
}
JS::Value WebContentConsoleClient::info()
{
StringBuilder html;
html.append("<span class=\"info\">");
html.append("(i) ");
html.append(escape_html_entities(vm().join_arguments()));
html.append("</span>");
print_html(html.string_view());
return JS::js_undefined();
}
JS::Value WebContentConsoleClient::debug()
{
StringBuilder html;
html.append("<span class=\"debug\">");
html.append("(d) ");
html.append(escape_html_entities(vm().join_arguments()));
html.append("</span>");
print_html(html.string_view());
return JS::js_undefined();
}
JS::Value WebContentConsoleClient::warn()
{
StringBuilder html;
html.append("<span class=\"warn\">");
html.append("(w) ");
html.append(escape_html_entities(vm().join_arguments()));
html.append("</span>");
print_html(html.string_view());
return JS::js_undefined();
}
JS::Value WebContentConsoleClient::error()
{
StringBuilder html;
html.append("<span class=\"error\">");
html.append("(e) ");
html.append(escape_html_entities(vm().join_arguments()));
html.append("</span>");
print_html(html.string_view());
return JS::js_undefined();
}
JS::Value WebContentConsoleClient::clear()
{
clear_output();
@ -225,4 +175,38 @@ JS::Value WebContentConsoleClient::assert_()
return JS::js_undefined();
}
// 2.3. Printer(logLevel, args[, options]), https://console.spec.whatwg.org/#printer
JS::ThrowCompletionOr<JS::Value> WebContentConsoleClient::printer(JS::Console::LogLevel log_level, Vector<JS::Value>& arguments)
{
auto output = String::join(" ", arguments);
m_console.output_debug_message(log_level, output);
StringBuilder html;
switch (log_level) {
case JS::Console::LogLevel::Debug:
html.append("<span class=\"debug\">(d) ");
break;
case JS::Console::LogLevel::Error:
html.append("<span class=\"error\">(e) ");
break;
case JS::Console::LogLevel::Info:
html.append("<span class=\"info\">(i) ");
break;
case JS::Console::LogLevel::Log:
html.append("<span class=\"log\"> ");
break;
case JS::Console::LogLevel::Warn:
html.append("<span class=\"warn\">(w) ");
break;
default:
html.append("<span>");
break;
}
html.append(escape_html_entities(output));
html.append("</span>");
print_html(html.string_view());
return JS::js_undefined();
}
}