RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-02 23:42:13 +00:00
Code Issues Activity Actions

LibWeb: Add the HTMLInputElement.type attribute

Browse source 
This makes React react to change events on text <input> elements. :^)
This commit is contained in:
Andreas Kling 2022-02-17 13:12:01 +01:00
parent 5f54b8dd6c
commit 2660795bcf
3 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -219,4 +219,18 @@ void HTMLInputElement::did_remove_attribute(FlyString const& name)
} }
} }
String HTMLInputElement::type() const
{
// FIXME: This should only reflect known values.
auto value = attribute(HTML::AttributeNames::type);
if (value.is_null())
return "text";
return value;
}
void HTMLInputElement::set_type(String const& type)
{
set_attribute(HTML::AttributeNames::type, type);
}
} }

4
Userland/Libraries/LibWeb/HTML/HTMLInputElement.h
View file

@ -20,7 +20,9 @@ public:
virtual RefPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override; virtual RefPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override;
String type() const { return attribute(HTML::AttributeNames::type); } String type() const;
void set_type(String const&);
String default_value() const { return attribute(HTML::AttributeNames::value); } String default_value() const { return attribute(HTML::AttributeNames::value); }
String name() const { return attribute(HTML::AttributeNames::name); } String name() const { return attribute(HTML::AttributeNames::name); }

2
Userland/Libraries/LibWeb/HTML/HTMLInputElement.idl
View file

@ -17,6 +17,8 @@ interface HTMLInputElement : HTMLElement {
[Reflect=dirname] attribute DOMString dirName; [Reflect=dirname] attribute DOMString dirName;
[Reflect=value] attribute DOMString defaultValue; [Reflect=value] attribute DOMString defaultValue;
attribute DOMString type;
[LegacyNullToEmptyString] attribute DOMString value; [LegacyNullToEmptyString] attribute DOMString value;
attribute boolean checked; attribute boolean checked;