RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-15 17:04:59 +00:00
Code Issues Activity Actions

Tests/AK: Re-enable HashTable<double> test

Browse source 
The incorrect UBSan alignment check that made this test fail has been
fixed in Clang 15.

Closes #13614
This commit is contained in:
Daniel Bertalan 2022-11-15 08:15:32 +01:00 • committed by Idan Horowitz
parent 8d65df935e
commit 269a931414
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Tests/AK/TestHashTable.cpp
View file

@ -268,8 +268,6 @@ TEST_CASE(floats)
EXPECT(table.contains(2.0f)); EXPECT(table.contains(2.0f));
} }
// FIXME: Enable this test once it doesn't trigger UBSAN.
#if 0
TEST_CASE(doubles) TEST_CASE(doubles)
{ {
HashTable<double> table; HashTable<double> table;
@ -281,7 +279,6 @@ TEST_CASE(doubles)
EXPECT(table.contains(1.0)); EXPECT(table.contains(1.0));
EXPECT(table.contains(2.0)); EXPECT(table.contains(2.0));
} }
#endif
// Inserting and removing a bunch of elements will "thrash" the table, leading to a lot of "deleted" markers. // Inserting and removing a bunch of elements will "thrash" the table, leading to a lot of "deleted" markers.
BENCHMARK_CASE(benchmark_thrashing) BENCHMARK_CASE(benchmark_thrashing)