RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 18:07:35 +00:00
Code Issues Activity Actions

LibWeb: Allow configuring the default favicon path

Browse source 
This is useful when using LibWeb in environments that aren't Serenity
This commit is contained in:
DexesTTP 2022-04-03 16:36:28 +02:00 • committed by Linus Groh
parent c5a249a949
commit 26bb95425d
2 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Loader/FrameLoader.cpp
View file

@ -26,13 +26,19 @@
namespace Web { namespace Web {
static String s_default_favicon_path = "/res/icons/16x16/app-browser.png";
static RefPtr<Gfx::Bitmap> s_default_favicon_bitmap; static RefPtr<Gfx::Bitmap> s_default_favicon_bitmap;
void FrameLoader::set_default_favicon_path(String path)
{
s_default_favicon_path = move(path);
}
FrameLoader::FrameLoader(HTML::BrowsingContext& browsing_context) FrameLoader::FrameLoader(HTML::BrowsingContext& browsing_context)
: m_browsing_context(browsing_context) : m_browsing_context(browsing_context)
{ {
if (!s_default_favicon_bitmap) { if (!s_default_favicon_bitmap) {
s_default_favicon_bitmap = Gfx::Bitmap::try_load_from_file("/res/icons/16x16/app-browser.png").release_value_but_fixme_should_propagate_errors(); s_default_favicon_bitmap = Gfx::Bitmap::try_load_from_file(s_default_favicon_path).release_value_but_fixme_should_propagate_errors();
VERIFY(s_default_favicon_bitmap); VERIFY(s_default_favicon_bitmap);
} }
} }
@ -281,7 +287,7 @@ void FrameLoader::load_favicon(RefPtr<Gfx::Bitmap> bitmap)
if (auto* page = browsing_context().page()) { if (auto* page = browsing_context().page()) {
if (bitmap) if (bitmap)
page->client().page_did_change_favicon(*bitmap); page->client().page_did_change_favicon(*bitmap);
else else if (s_default_favicon_bitmap)
page->client().page_did_change_favicon(*s_default_favicon_bitmap); page->client().page_did_change_favicon(*s_default_favicon_bitmap);
} }
} }

2
Userland/Libraries/LibWeb/Loader/FrameLoader.h
View file

@ -23,6 +23,8 @@ public:
IFrame, IFrame,
}; };
static void set_default_favicon_path(String);
explicit FrameLoader(HTML::BrowsingContext&); explicit FrameLoader(HTML::BrowsingContext&);
~FrameLoader(); ~FrameLoader();