mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 18:07:35 +00:00
CMake: Hide KMALLOC_VERIFY_NO_SPINLOCK_HELD so folks don't find it
Since I introduced this functionality there has been a steady stream of people building with `ALL_THE_DEBUG_MACROS` and trying to boot the system, and immediately hitting this assert. I have no idea why people try to build with all the debugging enabled, but I'm tired of seeing the bug reports about asserts we know are going to happen at this point. So I'm hiding this value under the new ENABLE_ALL_DEBUG_FACILITIES flag instead. This is only set by CI, and hopefully no-one will try to build with this thing (It's documented as not recommended). Fixes: #7527
This commit is contained in:
parent
d838a02e74
commit
26cb64573c
2 changed files with 8 additions and 1 deletions
|
@ -102,6 +102,12 @@ endif()
|
|||
if (ENABLE_ALL_DEBUG_FACILITIES)
|
||||
set(ENABLE_ALL_THE_DEBUG_MACROS ON)
|
||||
set(ENABLE_EXTRA_KERNEL_DEBUG_SYMBOLS ON)
|
||||
|
||||
# Immediately finds violations during boot, shouldn't be discoverable
|
||||
# by people who aren't working on fixing issues. Use this check to make
|
||||
# sure this code continues to build instead of all_debug_macros to avoid
|
||||
# people filing bugs.
|
||||
set(KMALLOC_VERIFY_NO_SPINLOCK_HELD ON)
|
||||
endif()
|
||||
|
||||
if (ENABLE_ALL_THE_DEBUG_MACROS)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue