RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibELF

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 10:34:11 -07:00 • committed by Brian Gianforcaro
parent 8f20c3334b
commit 271d82e23f
3 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibELF/DynamicObject.h
View file

@ -1,6 +1,7 @@
/* /*
* Copyright (c) 2019-2020, Andrew Kaster <akaster@serenityos.org> * Copyright (c) 2019-2020, Andrew Kaster <akaster@serenityos.org>
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com> * Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -107,7 +108,7 @@ public:
, m_name(name) , m_name(name)
{ {
} }
~Section() { } ~Section() = default;
StringView name() const { return m_name; } StringView name() const { return m_name; }
unsigned offset() const { return m_section_offset; } unsigned offset() const { return m_section_offset; }

5
Userland/Libraries/LibELF/Image.cpp
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -30,10 +31,6 @@ Image::Image(const u8* buffer, size_t size, bool verbose_logging)
{ {
} }
Image::~Image()
{
}
StringView Image::section_index_to_string(unsigned index) const StringView Image::section_index_to_string(unsigned index) const
{ {
VERIFY(m_valid); VERIFY(m_valid);

3
Userland/Libraries/LibELF/Image.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -22,7 +23,7 @@ public:
explicit Image(ReadonlyBytes, bool verbose_logging = true); explicit Image(ReadonlyBytes, bool verbose_logging = true);
explicit Image(const u8*, size_t, bool verbose_logging = true); explicit Image(const u8*, size_t, bool verbose_logging = true);
~Image(); ~Image() = default;
void dump() const; void dump() const;
bool is_valid() const { return m_valid; } bool is_valid() const { return m_valid; }
bool parse(); bool parse();