RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 10:27:34 +00:00
Code Issues Activity Actions

LibVideo: Fix string reading in Matroska

Browse source 
A string should never be longer than it's strlen according to
the specification
This commit is contained in:
Stephan Vedder 2023-11-27 10:12:47 +01:00 • committed by Luke Wilde
parent 1f55cc942d
commit 2732dd3633
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibVideo/Containers/Matroska/Reader.cpp
View file

@ -985,7 +985,8 @@ ErrorOr<DeprecatedString> Streamer::read_string()
auto string_length = TRY(read_variable_size_integer()); auto string_length = TRY(read_variable_size_integer());
if (remaining() < string_length) if (remaining() < string_length)
return Error::from_string_literal("String length extends past the end of the stream"); return Error::from_string_literal("String length extends past the end of the stream");
auto string_value = DeprecatedString(data_as_chars(), string_length); auto string_data = data_as_chars();
auto string_value = DeprecatedString(string_data, strnlen(string_data, string_length));
TRY(read_raw_octets(string_length)); TRY(read_raw_octets(string_length));
return string_value; return string_value;
} }