RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:57:43 +00:00
Code Issues Activity Actions

LibVideo/PlaybackManager: Organize playback states into virtual classes

Browse source 
Storing playback states in virtual classes allows the behavior to be
much more clearly written. Each `PlaybackStateHandler` subclass can
implement some event-handling functions to model their behavior, and
has functions to change its parent PlaybackManager's state to any other
state.

This will allow expanding the functionality of playback in the future,
for example to allow skipping a single frame forward/backward.
This commit is contained in:
Zaggy1024 2023-02-06 01:24:33 -06:00 • committed by Andreas Kling
parent a4c7672802
commit 275d57eb6f
3 changed files with 481 additions and 211 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/VideoPlayer/VideoPlayerWidget.cpp
View file

@ -56,8 +56,8 @@ ErrorOr<void> VideoPlayerWidget::setup_interface()
auto progress = value / static_cast<double>(m_seek_slider->max());
auto duration = m_playback_manager->duration().to_milliseconds();
Time timestamp = Time::from_milliseconds(static_cast<i64>(round(progress * static_cast<double>(duration))));
set_current_timestamp(timestamp);
m_playback_manager->seek_to_timestamp(timestamp);
set_current_timestamp(m_playback_manager->current_playback_time());
};
m_play_icon = TRY(Gfx::Bitmap::load_from_file("/res/icons/16x16/play.png"sv));
@ -237,6 +237,8 @@ void VideoPlayerWidget::event(Core::Event& event)
} else if (event.type() == Video::EventType::PlaybackStateChange) {
update_play_pause_icon();
event.accept();
} else if (event.type() == Video::EventType::FatalPlaybackError) {
close_file();
}
Widget::event(event);