RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:37:35 +00:00
Code Issues Activity Actions

Revert "Kernel/PCI: Allow to set the PCI IRQ line of a device"

Browse source 
This reverts commit 36a82188a8.

This register is write-only for the firmware (BIOS), and read-only for
us so we shouldn't set the PCI IRQ line never.
The firmware figured out the IRQ routing to the PIC for us, so changing
it won't affect anything. I was mistaken when I thought that changing
the value of this register will allow us to change its interrupt line,
like when changing a PCI BAR to relocate device resources as desired
with the requirements of the OS.
This commit is contained in:
Liav A 2021-04-02 14:08:14 +03:00 • committed by Andreas Kling
parent 2718d7c74c
commit 27bf91ab87
2 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/PCI/Access.cpp
View file

@ -222,11 +222,6 @@ u8 get_interrupt_line(Address address)
return read8(address, PCI_INTERRUPT_LINE);
}
void set_interrupt_line(Address address, u8 new_line)
{
write8(address, PCI_INTERRUPT_LINE, new_line);
}
u32 get_BAR0(Address address)
{
return read32(address, PCI_BAR0);