RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 17:07:47 +00:00
Code Issues Activity Actions

Games: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-16 11:44:57 -07:00 • committed by Linus Groh
parent 9521f71944
commit 27c30ca063
26 changed files with 41 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Games/Breakout/Game.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -26,10 +27,6 @@ Game::Game()
reset();
}
Game::~Game()
{
}
void Game::reset_paddle()
{
update(enclosing_int_rect(m_paddle.rect));

3
Userland/Games/Breakout/Game.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -18,7 +19,7 @@ public:
static const int game_width = 480;
static const int game_height = 500;
virtual ~Game() override;
virtual ~Game() override = default;
void set_paused(bool paused);

6
Userland/Games/Breakout/LevelSelectDialog.cpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -20,10 +20,6 @@ LevelSelectDialog::LevelSelectDialog(Window* parent_window)
build();
}
LevelSelectDialog::~LevelSelectDialog()
{
}
int LevelSelectDialog::show(int& board_number, Window* parent_window)
{
auto box = LevelSelectDialog::construct(parent_window);

4
Userland/Games/Breakout/LevelSelectDialog.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -12,7 +12,7 @@ namespace Breakout {
class LevelSelectDialog : public GUI::Dialog {
C_OBJECT(LevelSelectDialog)
public:
virtual ~LevelSelectDialog() override;
virtual ~LevelSelectDialog() override = default;
static int show(int& board_number, Window* parent_window);
int level() const { return m_level; }