RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 21:37:35 +00:00
Code Issues Activity Actions

Games: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-16 11:44:57 -07:00 • committed by Linus Groh
parent 9521f71944
commit 27c30ca063
26 changed files with 41 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Games/GameOfLife/Board.cpp
View file

@ -1,6 +1,7 @@
/*
* Copyright (c) 2021, Andres Crucitti <dasc495@gmail.com>
* Copyright (c) 2021, Linus Groh <linusg@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -14,10 +15,6 @@ Board::Board(size_t rows, size_t columns)
resize(rows, columns);
}
Board::~Board()
{
}
void Board::run_generation()
{
m_stalled = true;

3
Userland/Games/GameOfLife/Board.h
View file

@ -1,6 +1,7 @@
/*
* Copyright (c) 2021, Andres Crucitti <dasc495@gmail.com>
* Copyright (c) 2021, Linus Groh <linusg@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -14,7 +15,7 @@
class Board {
public:
Board(size_t rows, size_t columns);
~Board();
~Board() = default;
size_t columns() const { return m_columns; }
size_t rows() const { return m_rows; }

5
Userland/Games/GameOfLife/Pattern.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Ryan Wilson <ryan@rdwilson.xyz>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -16,10 +17,6 @@ Pattern::Pattern(Vector<String> pattern)
m_pattern = move(pattern);
}
Pattern::~Pattern()
{
}
void Pattern::set_action(GUI::Action* action)
{
m_action = action;

4
Userland/Games/GameOfLife/Pattern.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Ryan Wilson <ryan@rdwilson.xyz>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -11,10 +12,9 @@
#include <LibGUI/Event.h>
#include <LibGUI/Forward.h>
class Pattern {
class Pattern final {
public:
Pattern(Vector<String>);
virtual ~Pattern();
Vector<String> pattern() { return m_pattern; };
GUI::Action* action() { return m_action; }
void set_action(GUI::Action*);